New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup signal to trap SIGINT and gracefully stop server #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6e3982
to
0507d34
Compare
@@ -399,6 +399,14 @@ def setup_signals | |||
end | |||
|
|||
begin | |||
Signal.trap "SIGINT" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lower in this file
if Puma.jruby?
Signal.trap("INT") do
move those two together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
This way, when you send `SIGINT` to a running a server, when running via `rails s`, a graceful shutdown/stop will be performed. Before this, not trapping `SIGINT` would mean that either `Rails::Server#start` or `::Rack::Server#start` would be trapping `SIGINT` and exiting the process.
0507d34
to
d9a2358
Compare
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This way, when you send
SIGINT
to a server, when running viarails s
, a graceful shutdown/stop will be performed.Before this, not trapping
SIGINT
would mean that eitherRails::Server#start
or
::Rack::Server#start
would be trappingSIGINT
and exiting the process.Fix for: #1362
References:
::Rack::Server#start
's trapping ofSIGINT
.Replication of current/fixed behavior: