Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[close #1327] Fix double port bind in Rails #1383

Merged
merged 1 commit into from Aug 2, 2017
Merged

[close #1327] Fix double port bind in Rails #1383

merged 1 commit into from Aug 2, 2017

Commits on Aug 2, 2017

  1. [close #1327] Fix double port bind in Rails 

    The "default" configuration puma level is initialized with a "binds" of `tcp://0.0.0.0:9292`. Puma is designed to be able to bind to multiple ports. 

When a `:port` is sent from Rails along with an empty `user_supplied_options` then the port is treated as a "default". This is merged in with the system defaults, and then later converted into a "binds" via calling `config.port` in the `set_host_port_to_config` method. 

The bug comes due to the "level" of the configuration. Since both are being set on the same "level" the `port` call does not over-write the existing binds but instead prepends to the array. We can fix by ensuring that any binds in a given "level" are empty before setting it.
    @schneems
    schneems committed Aug 2, 2017
    Copy the full SHA
    0584a33 View commit details
    Browse the repository at this point in the history