Require puma/events in test helper #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the require for puma/events from the individual test files and into the main test helper. The reason for this was while I was debugging the `test_puma_server.rb` tests I was getting an error for an uninitialized constant for `Puma::Event`. Moving the require from the individual files to the test help means the `puma/events` will always be included instead of having to remember to do that. It makes debugging individual tests locally easier.
This was referenced Mar 15, 2018
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Moves the require for puma/events from the individual test files and
into the main test helper.
The reason for this was while I was debugging the
test_puma_server.rbtests I was getting an error for an uninitialized constant for
Puma::Event.Moving the require from the individual files to the test help means the
puma/eventswill always be included instead of having to remember todo that. It makes debugging individual tests locally easier.