Add Capistrano deploy note #175

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
Contributor

huacnlee commented Dec 14, 2012

No description provided.

👍 Thanks for this!

@martinisoft martinisoft commented on the diff Jan 4, 2013

README.md
@@ -132,6 +132,24 @@ Allowed commands: status, restart, halt, stop
If you want an easy way to manage multiple scripts at once check [tools/jungle](https://github.com/puma/puma/tree/master/tools/jungle) for an init.d script.
+## Capistrano deployment
+
+Puma (2.0.0 +) has included Capistrano [deploy script](https://github.com/plentz/puma/blob/master/lib/puma/capistrano.rb), you just need require that:
@martinisoft

martinisoft Jan 4, 2013

You probably want to make the URL point to the puma repo and not your fork.

@activars

activars Jan 14, 2013

I think it might also need to include:

require 'bundler/setup'

@linjunpop linjunpop commented on the diff Jan 15, 2013

README.md
@@ -132,6 +132,24 @@ Allowed commands: status, restart, halt, stop
If you want an easy way to manage multiple scripts at once check [tools/jungle](https://github.com/puma/puma/tree/master/tools/jungle) for an init.d script.
+## Capistrano deployment
+
+Puma (2.0.0 +) has included Capistrano [deploy script](https://github.com/plentz/puma/blob/master/lib/puma/capistrano.rb), you just need require that:
+
+config/deploy.rb
+
+```ruby
+require "puma/capistrano"
+```
+
+and then
+
+```bash
+$ cap deploy:start # to start puma app server
@linjunpop

linjunpop Jan 15, 2013

I think these commands should be

$ cap puma:start
$ cap puma:restart
$ cap puma:stop

So it will only trigger Puma tasks. Exclude those tasks which also hook into deploy:stop/start/restart.

@hron84

hron84 Feb 17, 2013

I am not agree. This implicitly says Puma integration with Capistano is seamless. These tasks can be named later.

@activars

activars Feb 18, 2013

I think it would be better to namespace under puma:start. Because this seamless means make is harder for people to define their own deploy flows. I do prefer explicitly define it myself.

Owner

evanphx commented Mar 18, 2013

I just merged some other cap PRs that included this language, so I'm going to ahead and close this. If you're not happy with the new language, please submit another PR.

evanphx closed this Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment