Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow semicolon in url-path #1934

merged 3 commits into from Aug 28, 2019


Copy link

@zarelit zarelit commented Aug 27, 2019

Allow unescaped semicolons in the URL, improves compatibility with applications that use it as a parameter separator such as Angular 2 or Redmine.

Fixes #1122

Copy link
Contributor Author

zarelit commented Aug 27, 2019

The tests on MacOSX are flaky, here are the same tests on the same commit, passing:

Copy link

😮 Thanks for pushing this up so quickly! Will review soon.

@nateberkopec nateberkopec merged commit beab7f0 into puma:master Aug 28, 2019
Copy link
Contributor Author

zarelit commented Aug 29, 2019

Thank you for the review and merge @evanphx @nateberkopec

costis added a commit to reevoo/puma that referenced this pull request Nov 4, 2019
* Allow unquoted semicolon in URL path
* Add test about semicolon
* Regenerate grammar to allow semicolon in request_path

We need to run revieworld-admin/apiv4 with puma on kubernetes. Puma
did not allow character ';' in urls, until version 4.2. In commit
beab7f0 in puma/puma they have added
support for ';'.

We tried running revieworld-admin/apiv4 with puma 4.2 but we
had intermittent 500s.

This is a backport of beab7f0 to
v3.12.1. We can use this for now, only for rw admin & apiv4, until we
find a proper solution.

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Semicolon in url-path
4 participants