Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Require Changelog at PR time #1991

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@schneems
Copy link
Contributor

commented Sep 25, 2019

We frequently forget to ask for a changelog entry, and then when we want to release the release maintainer has to go back and manually add them all. It would be better if the changelog was required at PR time so the original submitter can think of the best wording. If a PR is trivial people can add [ci skip] or [changelog skip].

This implementation uses github actions.

@schneems schneems changed the title Require Changelog at PR time [ci skip] Require Changelog at PR time Sep 25, 2019
@schneems schneems force-pushed the schneems/require-changelog branch from c608aff to c2cbf75 Sep 25, 2019
We frequently forget to ask for a changelog entry, and then when we want to release the release maintainer has to go back and manually add them all. It would be better if the changelog was required at PR time so the original submitter can think of the best wording. If a PR is trivial people can add `[ci skip]` or `[changelog skip]`.

This implementation uses github actions.
@schneems schneems force-pushed the schneems/require-changelog branch from c2cbf75 to d8f7f2f Sep 25, 2019
@nateberkopec

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

I think in a perfect world the action would also comment on failure, but that seems a lot more complicated to do with the actions kit rn, so lets 🚢

The changelog is History.md not CHANGELOG.md
@nateberkopec nateberkopec merged commit b9ed844 into master Sep 25, 2019
0 of 6 checks passed
0 of 6 checks passed
build
Details
OS: ubuntu-16.04 Ruby: 2.3.x
Details
OS: ubuntu-18.04 Ruby: 2.4.x
Details
OS: ubuntu-18.04 Ruby: 2.5.x
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@nateberkopec

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

whoops luckily i merged that 10 seconds after you pushed that fix 😆

dentarg added a commit to dentarg/puma that referenced this pull request Sep 25, 2019
Follow-up to puma#1991
nateberkopec added a commit that referenced this pull request Sep 26, 2019
Follow-up to #1991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.