Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file stream when reading pid from pidfile #2048

merged 2 commits into from Oct 21, 2019


Copy link

@hahmed hahmed commented Oct 21, 2019


Fixes closing of file stream when reading pid from pidfile - closes #1985

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to if this PR fixes a bug or adds a feature. If it doesn't need an entry to, I have added [changelog skip] to all commit messages.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the commit messages.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec nateberkopec merged commit 14782fd into puma:master Oct 21, 2019
@hahmed hahmed deleted the refactor-close-file-stream branch October 21, 2019 12:56
This was referenced Mar 9, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues. command, not closed?
2 participants