New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo "c" -> "user_config" for --extra_runtime_dependencies #2050
Merged
nateberkopec
merged 2 commits into
puma:master
from
olleolleolle:extra-runtime-dependencies-setting
Oct 25, 2019
Merged
Fix typo "c" -> "user_config" for --extra_runtime_dependencies #2050
nateberkopec
merged 2 commits into
puma:master
from
olleolleolle:extra-runtime-dependencies-setting
Oct 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
added a commit
to olleolleolle/puma
that referenced
this pull request
Oct 23, 2019
@nateberkopec I inspected this, and just was unable to locate I compared with |
composerinteralia
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test |
olleolleolle
added a commit
to olleolleolle/puma
that referenced
this pull request
Oct 24, 2019
82aae60
to
13dc698
Compare
(I added the simplest test for this code path - something that would have failed with the old code.) |
nateberkopec
requested changes
Oct 25, 2019
13dc698
to
b286f7e
Compare
Thanks @olleolleolle |
This was referenced Mar 9, 2021
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
The CLI option parsing code for
--extra-runtime-dependencies
had a typo in it.There was a
c
here, and it seemed, out of place.Comparing with
--prune_bundler
, which was mentioned next to this long option, we could try usinguser_config
instead.Your checklist for this pull request
[changelog skip]
to all commit messages.[ci skip]
to the commit messages.#issue
" to the PR description or my commit messages.