Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log binding on http:// for TCP bindings to make it clickable #2167

Closed
wants to merge 1 commit into from

Conversation

@ChrisBr
Copy link
Contributor

ChrisBr commented Mar 9, 2020

Description

since TCP mode is on the way out, how do you feel about (independently, and right away) changing the console message from * Listening on tcp://0.0.0.0:9292 to http:// instead? That would make it possible to cmd-double-click on the message Puma prints to open it immediately in a browser, which I miss a lot.

Fix #2166

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.
Fix #2166
@nateberkopec
Copy link
Member

nateberkopec commented Mar 9, 2020

Looks like you missed a spot or two, but right idea 👍 I'm not sure why it doesnt log the fail correctly, but it looks like failures are coming from TestBinder, perhaps TestBinder#test_allows_both_ssl_and_tcp

@ChrisBr
Copy link
Contributor Author

ChrisBr commented Mar 14, 2020

Ah thanks @nateberkopec, I will have another look 👍

@nateberkopec
Copy link
Member

nateberkopec commented Apr 15, 2020

Hey @ChrisBr - did you get stuck?

@nateberkopec
Copy link
Member

nateberkopec commented Apr 23, 2020

I looked at this locally today but I'm getting weird issues with tests and output that I think are unrelated.

@ChrisBr
Copy link
Contributor Author

ChrisBr commented Apr 23, 2020

Hey sorry, was a little bit busy! Will have another look tonight.

@nateberkopec
Copy link
Member

nateberkopec commented May 11, 2020

Something really weird is going on here, as trying to change the tests from tcp:// to http:// for me causes the tests to crash.

speedshop $ be ruby -Ilib test/test_binder.rb 
Run options: --seed 17431

# Running:

..S........F.....S....F speedshop $ 
@alexeevit
Copy link
Contributor

alexeevit commented Jun 27, 2020

Hey, I could take this. I ran tests and it works ok on my machine with macOS. Shall I make a new pull request with the branch synced with the master?

@nateberkopec
Copy link
Member

nateberkopec commented Jun 29, 2020

Please do!

@ChrisBr
Copy link
Contributor Author

ChrisBr commented Jun 29, 2020

Please feel free to take this over. Sorry for the delays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.