Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain rake-compiler version to 0.9.4 #2307

Merged
merged 1 commit into from Jul 16, 2020

Conversation

utkarsh2102
Copy link
Contributor

@utkarsh2102 utkarsh2102 commented Jul 8, 2020

Description

Constrain rake-compiler version to 0.9.4 to fix ClassNotFound exception when using MiniSSL with Java8.

Fixes: #2301

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>


Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Fixes: puma#2301

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Contributor Author

Pretty sure this failing check isn't related to this PR.
Here are Ruby issues about this:

@nateberkopec nateberkopec merged commit 95942e2 into puma:master Jul 16, 2020
@utkarsh2102 utkarsh2102 deleted the constrain-rake-compiler branch July 16, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit version of rake-compiler
2 participants