Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split TCP_CORK and TCP_INFO [changelog skip] #2372

Merged
merged 1 commit into from Sep 22, 2020
Merged

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Sep 18, 2020

Description

as requested by @headius in #2349

those two functions don't depend on each other

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.
pavel
@ahorek ahorek changed the title WIP: split TCP_CORK and TCP_INFO [changelog skip] split TCP_CORK and TCP_INFO [changelog skip] Sep 19, 2020
@headius
Copy link
Contributor

@headius headius commented Sep 20, 2020

👍 May be a moot point for JRuby since you added TCP_INFO support, but I think these should be uncoupled anyway.

@nateberkopec nateberkopec merged commit 7928173 into puma:master Sep 22, 2020
33 of 34 checks passed
33 of 34 checks passed
build
Details
build
Details
ubuntu-20.04 2.5
Details
ubuntu-20.04 2.7
Details
ubuntu-20.04 2.7
Details
ubuntu-20.04 jruby
Details
ubuntu-20.04 head
Details
windows-2019 2.7
Details
ubuntu-18.04 2.2
Details
ubuntu-18.04 2.3
Details
ubuntu-18.04 2.4
Details
ubuntu-18.04 2.5
Details
ubuntu-18.04 2.6
Details
ubuntu-18.04 2.7
Details
ubuntu-18.04 head
Details
ubuntu-18.04 jruby
Details
ubuntu-18.04 jruby-head
Details
ubuntu-18.04 truffleruby-head
Details
macos-10.15 2.2
Details
macos-10.15 2.3
Details
macos-10.15 2.4
Details
macos-10.15 2.5
Details
macos-10.15 2.6
Details
macos-10.15 2.7
Details
macos-10.15 head
Details
macos-10.15 jruby
Details
macos-10.15 truffleruby-head macos-10.15 truffleruby-head
Details
windows-2019 2.2
Details
windows-2019 2.3
Details
windows-2019 2.4
Details
windows-2019 2.5
Details
windows-2019 2.6
Details
windows-2019 2.7
Details
windows-2019 mingw
Details
@nateberkopec
Copy link
Member

@nateberkopec nateberkopec commented Sep 22, 2020

Thanks for the review @headius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.