Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History.md - add links [skip ci] #2383

Merged
merged 1 commit into from Sep 25, 2020
Merged

Conversation

@MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Sep 25, 2020

Description

Add links to History.md.

Leave the title attribute (date & user)?

I've got code for the first pass, I'll get it working for updates (grabs repo pr/issue info with GraphQL call).

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.
History.md Outdated
* Fix `not_token` being able to be set to true ([#1803])
* Fix "Hang on SIGTERM with ruby 2.6 in clustered mode" ([PR [#1741]], [#1674], [#1720], [#1730], [#1755])

[PR [#1741]]: https://github.com/puma/puma/pull/1741

This comment has been minimized.

@dentarg

dentarg Sep 25, 2020
Member

Not sure what's wrong, but the rendered file doesn't look good here:

Screenshot 2020-09-25 at 07 52 37

@dentarg
Copy link
Member

@dentarg dentarg commented Sep 25, 2020

I like this 👍

@MSP-Greg MSP-Greg force-pushed the MSP-Greg:history-link branch from 6911188 to 574b5b6 Sep 25, 2020
@MSP-Greg MSP-Greg force-pushed the MSP-Greg:history-link branch from 574b5b6 to 25d13a0 Sep 25, 2020
@MSP-Greg
Copy link
Contributor Author

@MSP-Greg MSP-Greg commented Sep 25, 2020

@dentarg

Sorry, I assumed that the first pass thru it contained no links. Fixed, reformatted some other things, I think it's correct now.

Copy link
Member

@dentarg dentarg left a comment

LGTM 👍

@MSP-Greg do we expect contributors to make links or will you run your tooling (sounds like you have something) every now and then?

@MSP-Greg
Copy link
Contributor Author

@MSP-Greg MSP-Greg commented Sep 25, 2020

@dentarg

do we expect contributors to make links

Please, no. That presupposes a knowledge of markdown, etc...

I'll work on the tooling, maybe add it to tools/history or something. I may need to add a json file that contains info about every PR and issue, as one never knows how far back they are, especially with issues. Right now, the file is about 450k. It also requires that one has a token to access the GH GraphQL API.

Also, the tooling could go in another Puma repo...

@nateberkopec nateberkopec merged commit d557c0a into puma:master Sep 25, 2020
3 checks passed
3 checks passed
${{ matrix.os }} ${{ matrix.ruby }}
Details
build
Details
${{ matrix.os }} ${{ matrix.ruby }}
Details
@nateberkopec
Copy link
Member

@nateberkopec nateberkopec commented Sep 25, 2020

Beautiful!

@MSP-Greg MSP-Greg deleted the MSP-Greg:history-link branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.