Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more @!attribute tags [skip ci] #2385

Merged
merged 1 commit into from Sep 25, 2020
Merged

Add more @!attribute tags [skip ci] #2385

merged 1 commit into from Sep 25, 2020

Conversation

@MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Sep 25, 2020

Description

This PR tags methods that can be classed as attributes, typically getters.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.
@nateberkopec nateberkopec merged commit 4e78060 into puma:master Sep 25, 2020
3 checks passed
3 checks passed
${{ matrix.os }} ${{ matrix.ruby }}
Details
build
Details
${{ matrix.os }} ${{ matrix.ruby }}
Details
@MSP-Greg MSP-Greg deleted the MSP-Greg:attr-tag branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.