Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cert_pem and key_pem with ssl_bind DSL #2728

Merged
merged 4 commits into from Oct 31, 2021

Conversation

dalibor
Copy link
Contributor

@dalibor dalibor commented Oct 27, 2021

Description

We need a way to specify cert and key objects or PEM strings in Puma configuration without relying on file paths. The use-case is when deploying to cloud provider and fetching certificates from Secrets Manager on application boot-up to avoid persisting the certificates on disk for security reasons.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
    • This PR is more than 100 lines, but it all comes together to support this feature
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

PR with clean history for: #2719

Copy link
Member

@dentarg dentarg left a comment

Looks solid to me, haven't tried to run this myself though

@MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Oct 29, 2021

Just built with PR, restarted with USR1 and USR2, sent curl requests, etc. LGTM.

@dentarg dentarg merged commit 5608248 into puma:master Oct 31, 2021
45 of 47 checks passed
@dnasevic-godaddy
Copy link

@dnasevic-godaddy dnasevic-godaddy commented Nov 1, 2021

@dentarg @MSP-Greg: Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants