Support for cert_pem and key_pem with ssl_bind DSL#2728
Merged
Conversation
DEPRECATED: Use assert_nil if expecting nil from test/test_binder.rb:265. This will fail in Minitest 6.
7 tasks
7 tasks
dentarg
approved these changes
Oct 28, 2021
dentarg
left a comment
dentarg
left a comment
Member
There was a problem hiding this comment.
Looks solid to me, haven't tried to run this myself though
Member
|
Just built with PR, restarted with USR1 and USR2, sent curl requests, etc. LGTM. |
MSP-Greg
approved these changes
Oct 29, 2021
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Fix deprecation warning DEPRECATED: Use assert_nil if expecting nil from test/test_binder.rb:265. This will fail in Minitest 6. * Extend MiniSSL with support for cert_pem and key_pem * Extend Puma ssl_bind DSL with support for cert_pem and cert_key * Make some variables in binder test more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need a way to specify cert and key objects or PEM strings in Puma configuration without relying on file paths. The use-case is when deploying to cloud provider and fetching certificates from Secrets Manager on application boot-up to avoid persisting the certificates on disk for security reasons.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.PR with clean history for: #2719