Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.rb - refactor code using @options[:remote_address] #2742

merged 1 commit into from Dec 12, 2021


Copy link

@MSP-Greg MSP-Greg commented Nov 2, 2021


server.rv - refactors code involving @options[:remote_address]used to initialize Client objects.

Refactors often involve personal code preferences. I felt this was an improvement, but I don't feel strongly about it...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg added waiting-for-review Waiting on review from anyone refactor labels Nov 2, 2021
@nateberkopec nateberkopec merged commit a25b73d into puma:master Dec 12, 2021
Copy link

Very nice

@MSP-Greg MSP-Greg deleted the client-remote-address branch December 12, 2021 21:26
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
refactor waiting-for-review Waiting on review from anyone
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants