Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.rb - rescue handling (Errno::EBADF) for @notify.close #2745

Merged
merged 1 commit into from Nov 3, 2021

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 2, 2021

Description

Handle @notify.close in the same manner as @check.close

CI has very infrequent failures. See https://github.com/puma/puma/runs/4085098935?check_suite_focus=true#step:9:385, which had the following error:

/Users/runner/work/puma/puma/lib/puma/server.rb:384:in `close': Bad file descriptor (Errno::EBADF)
	from /Users/runner/work/puma/puma/lib/puma/server.rb:384:in `handle_servers'
	from /Users/runner/work/puma/puma/lib/puma/server.rb:261:in `block in run'

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

dentarg
dentarg approved these changes Nov 3, 2021
@dentarg dentarg changed the title server.rb - fix @notify.close server.rb - rescue handling (Errno::EBADF) for @notify.close Nov 3, 2021
@dentarg dentarg merged commit 8833ca4 into puma:master Nov 3, 2021
46 of 47 checks passed
@MSP-Greg MSP-Greg deleted the fix-notify branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants