Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extconf.rb - fix openssl with old Windows builds #2757

Merged
merged 1 commit into from Nov 24, 2021

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 23, 2021

Description

Older Windows builds could compile with the wrong OpenSSL if more than one exists on the system. This occurs with the Actions windows-2019 image. Previous output from test log below:

                         Puma::MiniSSL                   OpenSSL
OPENSSL_LIBRARY_VERSION: OpenSSL 1.1.1  11 Sep 2018      OpenSSL 1.0.2j  26 Sep 2016
        OPENSSL_VERSION: OpenSSL 1.1.1l  24 Aug 2021     OpenSSL 1.0.2j  26 Sep 2016

CI did pass with the incorrect OpenSSL version, but if the app loaded Ruby's OpenSSL, two different OpenSSL libraries would be loaded. Also, the install wouldn't be portable. Probably not a good thing...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit ad131ce into puma:master Nov 24, 2021
47 checks passed
@MSP-Greg MSP-Greg deleted the old-win-extconf.rb branch Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant