Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localhost integration in ssl_bind #2764

Merged

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Dec 11, 2021

Close #2708
Close #2711

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg dentarg force-pushed the ssl_bind-localhost-self-signed-fix branch from 6fba34a to 3f0ba58 Compare Dec 12, 2021
@dentarg
Copy link
Member Author

@dentarg dentarg commented Dec 12, 2021

Added missing skip_if :jruby to test_ssl_self_signed_configuration_from_DSL

@dentarg
Copy link
Member Author

@dentarg dentarg commented Dec 12, 2021

macos-10.15 fail on ruby 2.2 was a strange one though 😕 Gem::RuntimeRequirementNotMetError: json requires Ruby version >= 2.3. but it worked on macos-11 with ruby 2.2 what is going on 🤯

@dentarg dentarg force-pushed the ssl_bind-localhost-self-signed-fix branch from 3f0ba58 to f2b573c Compare Dec 12, 2021
@MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Dec 12, 2021

@dentarg Again, working on intermittent CI issues. macos-10.15 just does weird stuff. With (yet another) CI patch, I haven't had failures/errors except with 10.15...

Close puma#2708
Close puma#2711

Co-authored-by: Marcin Olichwirowicz <marcin.olichwirowicz@nedap.com>
@dentarg dentarg force-pushed the ssl_bind-localhost-self-signed-fix branch from f2b573c to 2b75c64 Compare Dec 13, 2021
@dentarg dentarg requested a review from MSP-Greg Dec 13, 2021
@dentarg
Copy link
Member Author

@dentarg dentarg commented Dec 14, 2021

@MSP-Greg @nateberkopec WDYT?

@dentarg
Copy link
Member Author

@dentarg dentarg commented Jan 5, 2022

@nateberkopec could be included in next release?

@nateberkopec nateberkopec added the waiting-for-review label Jan 9, 2022
@nateberkopec nateberkopec merged commit 03be0aa into puma:master Jan 18, 2022
47 checks passed
@nateberkopec
Copy link
Member

@nateberkopec nateberkopec commented Jan 18, 2022

Cheers @dentarg! Thanks for your patience.

@dentarg dentarg deleted the ssl_bind-localhost-self-signed-fix branch Jan 18, 2022
dentarg added a commit to Starkast/wikimum that referenced this issue Jan 27, 2022
No need to care about the port gotchas with foreman now that we can use
ssl_bind in the Puma config: puma/puma#2764

Close #309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants