Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yaml (psych) requirement in StateFile #2784

Merged
merged 2 commits into from Jan 1, 2022

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Jan 1, 2022

Description

Update code and tests for StateFile:

  1. remove yaml requirement for lib code
  2. improve tests
  3. deprecate lib constants only used for testing

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title Remove yaml requirement in StateFile Remove yaml (psych) requirement in StateFile Jan 1, 2022
@MSP-Greg MSP-Greg merged commit 2b6968f into puma:master Jan 1, 2022
48 checks passed
@MSP-Greg MSP-Greg deleted the state-file branch Jan 1, 2022
MSP-Greg pushed a commit that referenced this issue Jan 27, 2022
Bug introduced in 2b6968f #2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this issue Apr 2, 2022
…2810)

Bug introduced in 2b6968f puma#2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this issue Apr 3, 2022
…2810)

Bug introduced in 2b6968f puma#2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants