Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log environment using option value #2799

Merged
merged 1 commit into from Jan 22, 2022

Conversation

ags
Copy link
Contributor

@ags ags commented Jan 12, 2022

Description

It's possible for the configured environment to be something other than RACK_ENV, e.g. APP_ENV or RAILS_ENV, but the runner will always log the value of RACK_ENV.

This changes the log output to show the configured environment value.

See https://github.com/puma/puma/blob/v5.5.2/lib/puma/configuration.rb#L203

It's possible for the configured environment to be something other than
`RACK_ENV`, e.g. `APP_ENV` or `RAILS_ENV`, but the runner will always
log the value of `RACK_ENV`.

This changes the log output to show the configured environment value.

See https://github.com/puma/puma/blob/v5.5.2/lib/puma/configuration.rb#L203
@ags ags force-pushed the log-environment-option branch from 2e8c0c0 to 93d3e63 Compare Jan 12, 2022
@nateberkopec
Copy link
Member

@nateberkopec nateberkopec commented Jan 13, 2022

Makes sense. That's a bug.

@nateberkopec nateberkopec merged commit ca2128f into puma:master Jan 22, 2022
42 of 48 checks passed
@ags ags deleted the log-environment-option branch Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants