Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two 'old-style-definition' compile warning #2807

merged 1 commit into from Jan 25, 2022


Copy link


Fix compile warnings in ext/puma_http11/mini_ssl.c and ext/puma_http11/puma_http11.c.

Closes #2806

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit d20915d into puma:master Jan 25, 2022
Copy link

@MSP-Greg Thanks so much! That was swift.

@MSP-Greg MSP-Greg deleted the old-style-definition branch January 25, 2022 15:28
Copy link

dentarg commented Jan 25, 2022

Was it ruby/ruby@ad150a1 that triggered the warnings (that we turn into errors) to start happening? Must have been something recent as test passed on ruby-head 3 days ago.

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Fix compile warnings in ext/puma_http11/mini_ssl.c and ext/puma_http11/puma_http11.c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

mini_ssl.c failure for warnings - error: old-style function definition "ubuntu-20.04 head"
3 participants