Correctly close app body for all code paths #3002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At present, some code paths will not close the app body. Add code to always hold a reference to the app body, so when code calling
lowlevel_error
is executed, the reference to the app body is maintained.test_rack_server.rb - add test_hijack_body_close - test for above
Small refactor of test_puma_server.rb. Takes too damn long.
test_puma_server.rb - add
test_lowlevel_error_body_close
to verify body close call when lowlevel_errorCloses #2999.
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.