Add request info to standard error rescue #955
Conversation
… (request) anymore)
… PATH_INFO as well
|
No, we don't touch STDERR directly here. You need to use |
|
Ok. Let me know if this is ok for you? I had to send |
| string_block = [ "#{Time.now}: #{kind} error: #{error.inspect}" ] | ||
| end | ||
| string_block << error.backtrace | ||
| @stderr.puts string_block.join("\n") |
There was a problem hiding this comment.
I'd prefer you just call @stderr.puts multiple times rather than make an array and then join it.
There was a problem hiding this comment.
I'd prefer multiple calls too. Sorry for not elaborating; the only reason I did a single call is so that there wont be the possibility (?) of other output from other @stderr.puts calls being interleaved among these debug lines. Do you think this is a valid concern / makes sense?
There was a problem hiding this comment.
Any comments, @evanphx ? Would appreciate your input on this.
Error backtraces should really come with this context (makes pinpointing where we should look much easier). Would be open to some discussion about how best to do the printing. Puma::Events#unknown_error could handle it... but I'd have to pass in the
envrequest object.