Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'file' objects don't seem to have proxyURL's #1014

Open
jankusanagi opened this issue Apr 27, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@jankusanagi
Copy link
Contributor

commented Apr 27, 2014

My client can upload "any" file now, creating objects of type 'file'. The resulting object has a link to the file in the 'fileUrl' property. But, unlike the 'stream' property of audio or video objects, this property is not a map with 'url' and optional 'pump_io':'proxyURL'.

Instead, the 'fileUrl' property is just a string, with the link to the file in the originating server. It would be good to have proxyURL's for it, as it's already done for 'image', 'audio' and 'video'. Otherwise, the attachment can't be downloaded by the addressees unless they're on the same server as the sender, or the post is completely public.

This is partially related to #873.

@evanp evanp added this to the 0.3.1 milestone Jun 22, 2014

@evanp

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2014

Agreed, it should be there.

@strugee

This comment has been minimized.

Copy link
Member

commented Aug 26, 2016

We're releasing 1.0.0 tomorrow and this isn't in it. Pushing to 1.1

@strugee strugee modified the milestones: 1.1, 1.0.0 Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.