New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #789

Closed
evanp opened this Issue Aug 24, 2013 · 16 comments

Comments

Projects
None yet
7 participants
@evanp
Contributor

evanp commented Aug 24, 2013

We need a docker.io image.

@niktrix

This comment has been minimized.

niktrix commented Mar 28, 2014

@prologic

This comment has been minimized.

prologic commented Jan 14, 2016

  • We need to make things configurable via docker run -e.
  • We should use the Alpine base image.
@adundovi

This comment has been minimized.

adundovi commented Mar 17, 2017

Here I wrote a minimal example based on the Alpine image and an external JSON config file:

FROM    alpine:3.5
LABEL maintainer adundovi@gmail.com

ENV     LC_ALL en_US.UTF-8

RUN apk add --no-cache nodejs git python make g++ graphicsmagick
RUN npm install -g databank-mongodb
RUN npm install -g pump.io
RUN adduser -D -g "" pumpio

ADD     pump.io.json /etc/

EXPOSE  8080
CMD  ["/usr/bin/pump"]
@strugee

This comment has been minimized.

Member

strugee commented Mar 18, 2017

@adundovi I'd like the Docker image to be something officially maintained by the pump.io project - that means in some "official" namespace on Docker Hub and maintained in-tree, in sync with the rest of the codebase. If you're willing to maintain this long-term as a member of the project I'd be thrilled if you submitted a PR so that we can iterate on it and get that going.

@adundovi

This comment has been minimized.

adundovi commented Mar 18, 2017

@strugee Well, I would like to contribute with that, but I am still fighting with different kind of "500 Internal Server Error" issues and there is no sense to submit anything if the stuff is not working. To add, I am not skillful with nodejs, which is making things harder to debug, thus I do not know if the bugs lie in my particular setup or in the pump.io code. If I will have the basic feature set working I will certainly polish and publish the docker code.

@strugee

This comment has been minimized.

Member

strugee commented Mar 19, 2017

@adundovi nonsense! PRs are a great way to get feedback on work-in-progress implementations. I regularly submit half-baked PRs to get early feedback on stuff :)

If you send a PR I can try to reproduce your 500 errors locally and try and find where the problem is. Just prefix the title with [WIP] or something.

@strugee

This comment has been minimized.

Member

strugee commented Mar 26, 2017

@adundovi are you still interested in doing this?

@adundovi

This comment has been minimized.

adundovi commented Mar 27, 2017

@strugee Here I put something to start with, but I don't know which repo is appropriate for the PR?

@strugee

This comment has been minimized.

Member

strugee commented Mar 27, 2017

@adundovi probably this one? I'm not familiar with Docker so I dunno if that'll make things difficult - if so we can create a separate repo. But I think we should aim for this one if possible

@niktrix

This comment has been minimized.

niktrix commented Mar 27, 2017

@strugee

This comment has been minimized.

Member

strugee commented Mar 27, 2017

@niktrix that Dockerfile seems really old... it's installing MongoDB from a third-party repo (which is unnecessary), it doesn't allow configuration, and it would be nice to base it on the Alpine image, so the image is smaller

@strugee

This comment has been minimized.

Member

strugee commented Mar 27, 2017

@adundovi @niktrix if one of you is interested in writing a modern Dockerfile that we can officially accept and sending a Pull Request including it, please say so. Otherwise I think I'll just write one myself

@niktrix

This comment has been minimized.

niktrix commented Mar 28, 2017

@strugee we dont have bandwidth to do so, thanks

@adundovi

This comment has been minimized.

adundovi commented Mar 28, 2017

@niktrix I used your Dockerfile as a starting point for mine.
@strugee I made a PR #1307 (this one is with the Alpine image)

@Serkan-devel

This comment has been minimized.

Serkan-devel commented Oct 30, 2017

Is there a docker image for the raspberry pi (3)?

@strugee

This comment has been minimized.

Member

strugee commented Oct 30, 2017

@Serkan-devel you should feel free to build one yourself using the Dockerfile in this repository, but we are not officially distributing Docker images yet due to #1418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment