Docker image

[evanp]

We need a docker.io image.

[nnn-gif]

docker pump image
https://index.docker.io/u/niktrix/docker-pump.io/

[prologic]

• We need to make things configurable via docker run -e.
• We should use the Alpine base image.

[adundovi]

Here I wrote a minimal example based on the Alpine image and an external JSON config file:

FROM    alpine:3.5
LABEL maintainer adundovi@gmail.com

ENV     LC_ALL en_US.UTF-8

RUN apk add --no-cache nodejs git python make g++ graphicsmagick
RUN npm install -g databank-mongodb
RUN npm install -g pump.io
RUN adduser -D -g "" pumpio

ADD     pump.io.json /etc/

EXPOSE  8080
CMD  ["/usr/bin/pump"]

[strugee]

@adundovi I'd like the Docker image to be something officially maintained by the pump.io project - that means in some "official" namespace on Docker Hub and maintained in-tree, in sync with the rest of the codebase. If you're willing to maintain this long-term as a member of the project I'd be thrilled if you submitted a PR so that we can iterate on it and get that going.

[adundovi]

@strugee Well, I would like to contribute with that, but I am still fighting with different kind of "500 Internal Server Error" issues and there is no sense to submit anything if the stuff is not working. To add, I am not skillful with nodejs, which is making things harder to debug, thus I do not know if the bugs lie in my particular setup or in the pump.io code. If I will have the basic feature set working I will certainly polish and publish the docker code.

[strugee]

@adundovi nonsense! PRs are a great way to get feedback on work-in-progress implementations. I regularly submit half-baked PRs to get early feedback on stuff :)

If you send a PR I can try to reproduce your 500 errors locally and try and find where the problem is. Just prefix the title with [WIP] or something.

[strugee]

@adundovi are you still interested in doing this?

[adundovi]

@strugee Here I put something to start with, but I don't know which repo is appropriate for the PR?

[strugee]

@adundovi probably this one? I'm not familiar with Docker so I dunno if that'll make things difficult - if so we can create a separate repo. But I think we should aim for this one if possible

[nnn-gif]

will this work? https://github.com/niktrix/docker-pump.io

…

On Mon, Mar 27, 2017 at 10:58 AM, Alex Jordan ***@***.***> wrote: @adundovi <https://github.com/adundovi> probably this one? I'm not familiar with Docker so I dunno if that'll make things difficult - if so we can create a separate repo. But I think we should aim for this one if possible — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#789 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM9ZqdQjBYf99rRWgtaszqikKyLFZ2Eks5rp0jvgaJpZM4A7r7l> .

-- Nitin Gurbani http://niktrix.in

[strugee]

@Niktrix that Dockerfile seems really old... it's installing MongoDB from a third-party repo (which is unnecessary), it doesn't allow configuration, and it would be nice to base it on the Alpine image, so the image is smaller

[strugee]

@adundovi @Niktrix if one of you is interested in writing a modern Dockerfile that we can officially accept and sending a Pull Request including it, please say so. Otherwise I think I'll just write one myself