Switch from utml to Jade #1170

Merged
merged 90 commits into from Sep 4, 2016

Conversation

Projects
None yet
1 participant
@strugee
Member

strugee commented Jun 1, 2016

This is almost, almost ready to merge to master. So I'm opening this PR so we can all look at the diff, etc.

strugee added some commits May 21, 2016

@strugee strugee changed the title from Switch utml to Jade to Switch from utml to Jade Jun 1, 2016

strugee added some commits Jun 1, 2016

strugee added some commits Aug 8, 2016

Add a missing space between buttons
Specifically, the messages button and the notifications button.
Work around npm not building Jade for Git installs
After install, we check to see if there are as many built files as there
are templates. If there aren't, we run a build.

This will never run on normal installs, because the built files end up
in package tarballs. However, Git installs don't work like that, so we
have to manually run the build ourselves.
@strugee

This comment has been minimized.

Show comment
Hide comment
@strugee

strugee Aug 12, 2016

Member

Wow. Should've mentioned: #1167 is the tracking issue for this.

Member

strugee commented Aug 12, 2016

Wow. Should've mentioned: #1167 is the tracking issue for this.

strugee added some commits Aug 13, 2016

Use tr to split $PATH instead of sed
FreeBSD's sed, and OS X's too, won't take literal newlines in an s/
command, which means that our logic to get the install path doesn't work
and we always rebuild the Jade (and get warnings on stderr).

Therefore, switch to tr, which can handle newlines just fine.
@strugee

This comment has been minimized.

Show comment
Hide comment
@strugee

strugee Sep 3, 2016

Member

Current problems (that we know about):

  • The bio field in settings is busted
  • Ditto for picture uploads
Member

strugee commented Sep 3, 2016

Current problems (that we know about):

  • The bio field in settings is busted
  • Ditto for picture uploads

@strugee strugee merged commit bee52fb into master Sep 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@strugee strugee deleted the utml-to-jade branch Sep 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment