Fix wrong session validation in uploads #1438
Conversation
|
Definitely a regression, really nice catch @vxcamiloxv. 23e6a97 should have fixed this but didn't. Left some minor nits inline but overall this looks super great. Can you edit the commit messages so the first one says "Fix session middleware usage in uploads", with " As always thanks so much for your patience! |
| @@ -187,6 +188,57 @@ suite.addBatch({ | |||
| assert.ifError(err); | |||
| } | |||
| }, | |||
| "and we get the file from web interface without login": { | |||
strugee
Jan 25, 2018
Member
"the web interface" instead of "web interface"; "logging in" instead of "login"
"the web interface" instead of "web interface"; "logging in" instead of "login"
vxcamiloxv
Feb 4, 2018
Author
Member
Done,
Done,
| br.assert.status(403); | ||
| } | ||
| }, | ||
| "and we login for try get file": { |
strugee
Jan 25, 2018
Member
"and we login and try to get the file"
"and we login and try to get the file"
vxcamiloxv
Feb 4, 2018
Author
Member
Done.
Done.
| assert.ifError(err); | ||
| br.assert.success(); | ||
| }, | ||
| "and we get the file from web interface with login": { |
strugee
Jan 25, 2018
Member
s/with login/while logged in/
s/with login/while logged in/
strugee
Jan 25, 2018
Member
And add a "the" before "web interface" too.
And add a "the" before "web interface" too.
vxcamiloxv
Feb 4, 2018
Author
Member
Done.
Done.
|
Also, I assume you tested the test? I.e. reverting the first commit causes the test to fail? |
vxcamiloxv
force-pushed the
vxcamiloxv:fix-uploads-session
branch
3 times, most recently
from
53f3e42
to
d7c992b
vxcamiloxv
force-pushed the
vxcamiloxv:fix-uploads-session
branch
from
d7c992b
to
bd564fb
|
@strugee yes, if you revert the commit the test will fail |
|
LGTM. Thanks very much @vxcamiloxv |
|
;) |
app.sessioninstance not existsbefore pump 4.x
sessionmiddleware was living inappinstance > app.jsCloses: #1435