Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix wrong session validation in uploads #1438
Conversation
vxcamiloxv
requested a review
from
strugee
Nov 2, 2017
vxcamiloxv
added
bug
regression
labels
Nov 23, 2017
strugee
requested changes
Jan 25, 2018
Definitely a regression, really nice catch @vxcamiloxv. 23e6a97 should have fixed this but didn't.
Left some minor nits inline but overall this looks super great. Can you edit the commit messages so the first one says "Fix session middleware usage in uploads", with "app.session is no longer the session middleware as of 23e6a97" (that way we have a nice reference as to when the regression was introduced)? The second one can be shortened to "Test viewing uploads from the web interface" too.
As always thanks so much for your patience!
| @@ -187,6 +188,57 @@ suite.addBatch({ | ||
| assert.ifError(err); | ||
| } | ||
| }, | ||
| "and we get the file from web interface without login": { |
This comment has been minimized.
This comment has been minimized.
strugee
Jan 25, 2018
Member
"the web interface" instead of "web interface"; "logging in" instead of "login"
This comment has been minimized.
This comment has been minimized.
| br.assert.status(403); | ||
| } | ||
| }, | ||
| "and we login for try get file": { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| assert.ifError(err); | ||
| br.assert.success(); | ||
| }, | ||
| "and we get the file from web interface with login": { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Also, I assume you tested the test? I.e. reverting the first commit causes the test to fail? |
vxcamiloxv
added some commits
Sep 4, 2017
This comment has been minimized.
This comment has been minimized.
|
@strugee yes, if you revert the commit the test will fail |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Feb 4, 2018
•
strugee
merged commit 4a63619
into
pump-io:master
Feb 12, 2018
vxcamiloxv
deleted the
vxcamiloxv:fix-uploads-session
branch
Feb 12, 2018
This comment has been minimized.
This comment has been minimized.
|
;) |
vxcamiloxv commentedSep 4, 2017
•
edited
app.sessioninstance not existsbefore pump 4.x
sessionmiddleware was living inappinstance > app.jsCloses: #1435