first move from preg_replace /e to preg_replace_callback #90

Merged
merged 1 commit into from Aug 18, 2013

Conversation

Projects
None yet
2 participants
@remicollet
Contributor

remicollet commented Mar 21, 2013

From http://www.php.net/manual/en/reference.pcre.pattern.modifiers.php

Use of this modifier is discouraged, as it can easily introduce security vulnerabilites: "

and

This feature has been DEPRECATED as of PHP 5.5.0. Relying on this feature is highly discouraged.

This first change, remove 1 usage of /e modifier and use preg_replace_callback (available in all PHP versions)

If you agree on this change, I will work on the other use of the /e

ashcs added a commit that referenced this pull request Aug 18, 2013

Merge pull request #90 from remicollet/issue-preg
first move from preg_replace /e to preg_replace_callback

@ashcs ashcs merged commit f5aac16 into punbb:master Aug 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment