puneet kandhari puneetk

@puneetk
  • @puneetk 46b9e75
    Fixes because iggy is stubborn on consistency
puneetk commented on issue saltstack/salt#22052
@puneetk

This affects an upgrade path, please be documenting in big letters. any reason we didnt use a config to gate this option ?

puneetk commented on pull request saltstack-formulas/sysstat-formula#9
@puneetk

I don't remember there being any discussion of changing foo-formula/foo/files to foo-formula/foo/sources I have moved the one sources file that w…

@puneetk
  • @puneetk 23aa5bd
    Code Review updates for README.rst, to clarify backwards incompatibility
puneetk commented on pull request saltstack-formulas/sysctl-formula#2
@puneetk

I can document those changes into the readme On Apr 6, 2015, at 10:15 PM, Brian Jackson notifications@github.com wrote: moving everything under lo…

puneetk commented on pull request saltstack-formulas/sysstat-formula#9
@puneetk

The reason i left the default in there is because it allows the user, to add as many blocks of such kind as needed. On Apr 6, 2015, at 8:32 PM, B…

puneetk commented on pull request saltstack-formulas/sysctl-formula#2
@puneetk

at most i can document the changes that seem breaking, what changes are you thinking are backwards incompatible. On Apr 6, 2015, at 8:39 PM, Bria…

@puneetk
Make the formula fully pillar driven/customizable
1 commit with 89 additions and 43 deletions
@puneetk
  • @puneetk 38eb852
    Make the formula fully pillar driven/customizable
@puneetk
Adding note to documentation stating that the formula works in 2014.7 +
1 commit with 4 additions and 1 deletion
@puneetk
  • @puneetk 7beb4a8
    Adding note to documentation stating that the formula works in 2014.7 +
@puneetk
Make the formula fully pillar driven/customizable
1 commit with 129 additions and 47 deletions
@puneetk
  • @puneetk 459dd6c
    Make the formula fully pillar driven/customizable
@puneetk

should we add a disclaimer for supported versions ? I can write one up Puneet On Apr 4, 2015, at 21:29, Nitin Madhok notifications@github.com wr…

@puneetk

@nmadhok It works fine in 2014.7+ versions # -*- coding: utf-8 -*- # vim: ft=sls {% set read_only_folders = ['/usr/local/sbin','/usr/local/bin','…

@puneetk

hmm my bad, my assumption was names is global to all state functions Puneet On Apr 4, 2015, at 16:45, Nitin Madhok notifications@github.com wrote:

@puneetk

does it not work or a stylistic issue. Puneet On Apr 4, 2015, at 13:37, Nitin Madhok notifications@github.com wrote: I'm not sure if this is the…

@puneetk
Update minimal_access.sls
1 commit with 6 additions and 5 deletions
@puneetk
  • @puneetk 0ee569b
    Update minimal_access.sls
puneetk closed pull request saltstack/salt-vim#30
@puneetk
Add in jinja.vim as from Jinja Integration docs
puneetk commented on pull request saltstack/salt-vim#30
@puneetk

sounds good, thanks Puneet On Mar 19, 2015, at 18:35, Nick Dewing notifications@github.com wrote: You could add autocmd BufNewFile,BufRead .j2,.…

puneetk commented on pull request saltstack-formulas/salt-formula#106
@puneetk

:100:

@puneetk

I think iggy is recommending instead of possibly over writing the global {{ salt }} variable, we use a different variable name in the files. So ins…

@puneetk

Is there a reason we are moving all the logic to templates ? The state files have the collectd_settings variable already setup it would be much cle…

@puneetk
puneetk opened pull request saltstack/salt-vim#30
@puneetk
Add in jinja.vim as from Jinja Integration docs
1 commit with 113 additions and 0 deletions