Specify which jars to copy manually #1

Closed
pupeno opened this Issue Sep 3, 2015 · 4 comments

Projects

None yet

2 participants

@pupeno
Owner
pupeno commented Sep 3, 2015

At this point, this plug in only implements copying the jars that are specified as the java-agents as this was the goal for this plug in. Extending it to be able to copy other jars, even manually specified ones won't be hard, but it'll be only implemented if clearly needed.

If you need this, please, comment on this issue and/or send a pull request. This is in our roadmap but won't happen until it's needed.

@dtanzer
dtanzer commented Oct 5, 2015

I am using jar copier for a dependency that is not a java agent. For now, I have declared it as a java agent so jar-copier will pick it up. Anyway, this is just a workaround, so I would love to see this issue fixed.

Please note: I only copy on of my dependencies, so it would be great if I could manually specify which dependencies should be copied.

@pupeno
Owner
pupeno commented Oct 5, 2015

I didn't know if this use case existed. Thanks for reporting it. Can you provide more information about the case? I'm curious.

@dtanzer
dtanzer commented Oct 6, 2015

I have a dependency, and I want to deploy it in the resources folder of my ring server, so others can download it or use it with UrlClassloader. The server does not use this code, it only provides it for others. The idea is that the server should always contain this library in the correct version.

It's probably a very rare use case :) And for now, I can live with marking it as a java agent...

@pupeno pupeno added a commit that closed this issue Nov 18, 2015
@pupeno @pupeno + Copy non-java agent jars as well and thorough testing for that case a…
…s well as misconfigurations. Closes #1.
83315d6
@pupeno pupeno closed this in 83315d6 Nov 18, 2015
@pupeno
Owner
pupeno commented Nov 18, 2015

This is now released, in version 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment