New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:working-directory option to specify the working directory for Node.js #12

Merged
merged 1 commit into from Dec 11, 2015

Conversation

Projects
None yet
2 participants
@eploko
Contributor

eploko commented Dec 2, 2015

This adds the option mentioned in pupeno/prerenderer#11

@@ -70,10 +74,13 @@
.deleteOnExit))
:start-timeout 5000
:wait false
:noop-when-stopped false}
:noop-when-stopped false
:working-directory "."}

This comment has been minimized.

@pupeno

pupeno Dec 3, 2015

Owner

I'm just wondering, should :working-directory be "." by default or should it be nil and have the old behaviour in that case? What do you think?

Otherwise, is "." cross platform?

@pupeno

pupeno Dec 3, 2015

Owner

I'm just wondering, should :working-directory be "." by default or should it be nil and have the old behaviour in that case? What do you think?

Otherwise, is "." cross platform?

This comment has been minimized.

@eploko

eploko Dec 12, 2015

Contributor

"." should work fine at least on any bsd/linux/osx/windows. I'd leave it as is and fix if any issues arise, which I doubt would happen.

@eploko

eploko Dec 12, 2015

Contributor

"." should work fine at least on any bsd/linux/osx/windows. I'd leave it as is and fix if any issues arise, which I doubt would happen.

(println "File" (:path js-engine) "appeared. Pfiuuu!")))))
(let [path (:path js-engine)
working-directory (:working-directory js-engine ".")
full-path (.getAbsolutePath (java.io.File. working-directory path))]

This comment has been minimized.

@pupeno

pupeno Dec 3, 2015

Owner

Are there any chances of getAbsolutePath failing or giving surprising results here?

@pupeno

pupeno Dec 3, 2015

Owner

Are there any chances of getAbsolutePath failing or giving surprising results here?

This comment has been minimized.

@eploko

eploko Dec 12, 2015

Contributor

None that I'm aware of.

@eploko

eploko Dec 12, 2015

Contributor

None that I'm aware of.

@pupeno pupeno merged commit e0a0775 into pupeno:master Dec 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment