Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract pupil_detectors into a separate repo #1642

Open
wants to merge 47 commits into
base: develop
from

Conversation

@romanroibu
Copy link
Member

romanroibu commented Sep 17, 2019

Requires pupil-detectors:

pip3 install git+https://github.com/pupil-labs/pupil-detectors.git --user --force -vvv
romanroibu and others added 26 commits Sep 17, 2019
Instances of this class hide all knowledge regarding pupil_detectors and expose an interface for the various UI lifecycle events and UI components. It also lazily imports symbols from pupil_detectors.plugins on init.
pupil_src/launchables/eye.py Outdated Show resolved Hide resolved
@papr papr marked this pull request as ready for review Nov 6, 2019
@papr papr requested review from papr and pfaion Nov 6, 2019
@pfaion pfaion changed the base branch from master to develop Nov 21, 2019
pfaion added 4 commits Dec 9, 2019
# Conflicts:
#	pupil_src/launchables/eye.py
#	pupil_src/shared_modules/pupil_detectors/detector_2d.pyx
#	pupil_src/tests/pupil_detectors/test_distance_point_line.py
#	pupil_src/tests/pupil_detectors/test_solve_npn.py
Copy link
Contributor

pfaion left a comment

So far so good. What I noticed though:

Previously you could switch between 2d/3d detector in the eye process, when detection & mapping mode was set to 2d. Now this is not possible anymore, but detection & mapping mode determines the mode of the eye processes completely. Is this what we want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.