Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csv test not working on windows #1724

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@pfaion
Copy link
Contributor

pfaion commented Nov 6, 2019

Python's csv library specifies that files passed to csv readers/writers have to be opened with newline="" or this won't work on windows.
See https://docs.python.org/3/library/csv.html#id3

Python's csv library specifies that files passed to csv readers/writers have to be opened with `newline=""` or this won't work on windows.
See https://docs.python.org/3/library/csv.html#id3
@pfaion pfaion requested a review from romanroibu Nov 6, 2019
@papr
papr approved these changes Nov 6, 2019
@papr papr merged commit ba63bfb into master Nov 6, 2019
@papr papr deleted the fix-csv-test-windows branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.