From 04fbbd7cf00852fa5b8ecf878f7cb34c9796453d Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Tue, 15 Jan 2019 11:37:53 -0800
Subject: [PATCH] fix(network): relax request matching heuristic (#3775)

Drop requirement for matching "origin" and "content-type" headers
in requests and request interceptions. This way javascript redirects
that use form submission start working.

Fix #3684.
---
 lib/NetworkManager.js | 4 +++-
 test/network.spec.js  | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/NetworkManager.js b/lib/NetworkManager.js
index 693478fa336e8..be73442a40076 100644
--- a/lib/NetworkManager.js
+++ b/lib/NetworkManager.js
@@ -651,6 +651,8 @@ class Response {
 }
 helper.tracePublicAPI(Response);
 
+const IGNORED_HEADERS = new Set(['accept', 'referer', 'x-devtools-emulate-network-conditions-client-id', 'cookie', 'origin', 'content-type']);
+
 /**
  * @param {!Protocol.Network.Request} request
  * @return {string}
@@ -677,7 +679,7 @@ function generateRequestHash(request) {
     for (let header of headers) {
       const headerValue = request.headers[header];
       header = header.toLowerCase();
-      if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id' || header === 'cookie')
+      if (IGNORED_HEADERS.has(header))
         continue;
       hash.headers[header] = headerValue;
     }
diff --git a/test/network.spec.js b/test/network.spec.js
index 4e36a836118d0..a2d37440c19f0 100644
--- a/test/network.spec.js
+++ b/test/network.spec.js
@@ -266,7 +266,7 @@ module.exports.addTests = function({testRunner, expect}) {
       expect(response.ok()).toBe(true);
       expect(response.remoteAddress().port).toBe(server.PORT);
     });
-    xit('should work when POST is redirected with 302', async({page, server}) => {
+    it('should work when POST is redirected with 302', async({page, server}) => {
       server.setRedirect('/rredirect', '/empty.html');
       await page.goto(server.EMPTY_PAGE);
       await page.setRequestInterception(true);