From 25d363bf9c18676a8f8527aec67155836c481346 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Thu, 28 Apr 2022 11:51:57 -0300 Subject: [PATCH] test: move async predicate to waitForResponse describe (#8285) --- test/page.spec.ts | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/test/page.spec.ts b/test/page.spec.ts index 8b1eb2b4bb150..d56cf51bd4563 100644 --- a/test/page.spec.ts +++ b/test/page.spec.ts @@ -763,21 +763,6 @@ describe('Page', function () { .catch((error_) => (error = error_)); expect(error).toBeInstanceOf(puppeteer.errors.TimeoutError); }); - it('should work with async predicate', async () => { - const { page, server } = getTestState(); - await page.goto(server.EMPTY_PAGE); - const [response] = await Promise.all([ - page.waitForResponse(async (response) => { - return response.url() === server.PREFIX + '/digits/2.png'; - }), - page.evaluate(() => { - fetch('/digits/1.png'); - fetch('/digits/2.png'); - fetch('/digits/3.png'); - }), - ]); - expect(response.url()).toBe(server.PREFIX + '/digits/2.png'); - }); it('should work with no timeout', async () => { const { page, server } = getTestState(); @@ -846,6 +831,21 @@ describe('Page', function () { ]); expect(response.url()).toBe(server.PREFIX + '/digits/2.png'); }); + it('should work with async predicate', async () => { + const { page, server } = getTestState(); + await page.goto(server.EMPTY_PAGE); + const [response] = await Promise.all([ + page.waitForResponse(async (response) => { + return response.url() === server.PREFIX + '/digits/2.png'; + }), + page.evaluate(() => { + fetch('/digits/1.png'); + fetch('/digits/2.png'); + fetch('/digits/3.png'); + }), + ]); + expect(response.url()).toBe(server.PREFIX + '/digits/2.png'); + }); it('should work with no timeout', async () => { const { page, server } = getTestState();