From 3c516f2114fa36b39b1484315a0e9c56478b2cd4 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Thu, 31 Jan 2019 17:33:38 -0800 Subject: [PATCH] chore: move static constructor to the top (#3873) --- lib/Browser.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/Browser.js b/lib/Browser.js index 8d2a5929060e4..88c177ad5cd5d 100644 --- a/lib/Browser.js +++ b/lib/Browser.js @@ -21,6 +21,20 @@ const {TaskQueue} = require('./TaskQueue'); const {Events} = require('./Events'); class Browser extends EventEmitter { + /** + * @param {!Puppeteer.Connection} connection + * @param {!Array} contextIds + * @param {boolean} ignoreHTTPSErrors + * @param {?Puppeteer.Viewport} defaultViewport + * @param {?Puppeteer.ChildProcess} process + * @param {function()=} closeCallback + */ + static async create(connection, contextIds, ignoreHTTPSErrors, defaultViewport, process, closeCallback) { + const browser = new Browser(connection, contextIds, ignoreHTTPSErrors, defaultViewport, process, closeCallback); + await connection.send('Target.setDiscoverTargets', {discover: true}); + return browser; + } + /** * @param {!Puppeteer.Connection} connection * @param {!Array} contextIds @@ -91,20 +105,6 @@ class Browser extends EventEmitter { this._contexts.delete(contextId); } - /** - * @param {!Puppeteer.Connection} connection - * @param {!Array} contextIds - * @param {boolean} ignoreHTTPSErrors - * @param {?Puppeteer.Viewport} defaultViewport - * @param {?Puppeteer.ChildProcess} process - * @param {function()=} closeCallback - */ - static async create(connection, contextIds, ignoreHTTPSErrors, defaultViewport, process, closeCallback) { - const browser = new Browser(connection, contextIds, ignoreHTTPSErrors, defaultViewport, process, closeCallback); - await connection.send('Target.setDiscoverTargets', {discover: true}); - return browser; - } - /** * @param {!Protocol.Target.targetCreatedPayload} event */