From 6784f1c03bcaa6ce55f3e232a4be5ed32c67a43e Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 17 Nov 2022 17:27:07 +0100 Subject: [PATCH] docs: fix typo in Viewport fields (#9293) The `deviceScalarFactor` field of `Viewport` is actually named `deviceScaleFactor`. --- docs/contributing.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/contributing.md b/docs/contributing.md index 417fb3b0513d8..9495f1282b7a1 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -322,3 +322,21 @@ In the event release-please fails, the following needs to be done: 2. Create a GitHub release for each package, following the practice of previous releases. + +## Bug and PR triage + +[Check incoming bug reports](https://github.com/puppeteer/puppeteer/issues) that do not have a `confirmed` or `needs-feedback` label: + +1. Make sure the issue labeled as either `bug` or `feature`. +2. If the issue does not have a clear repro or you cannot repro, ask for the repro and set the `needs-feedback` label. +3. Follow-up on the issues you previously asked for a feedback on (you should get a notification on GitHub when the user responds). +4. If the user does not provide feedback, the issue will be closed by the stale bot eventually. +5. If you are able to reproduce the issue, add the label "confirmed". +6. If the bug is on the Chromium side, create a corresponding crbug.com issue and label the Github issue with the "upstream" label and post a link to crbug.com in the comments. +7. If the issue is not related to either Puppeteer or Chromium, close the issue. +8. If the issue is about missing/incorrect documentation, label it as `documentation`. + +Issues with PDFs: + +1. If the issue reproduces using the regular print dialog and/or headful, file a crbug.com against the Blink Layout component. +2. If the issue is specific to the headless headless, file an issue on crbug.com against the headless component.