From c185eeef6119141ebc07f07d46ae0dcb16a555f3 Mon Sep 17 00:00:00 2001 From: jxltom Date: Thu, 15 Nov 2018 03:41:51 +0800 Subject: [PATCH] feat(install): support configurations in package.json (#3449) This PR support set ```puppeteer_skip_chromium_download```, ```puppeteer_download_host``` and ```puppeteer_chromium_revision``` in ```config``` of ```package.json``` Fixes #2262 --- install.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/install.js b/install.js index 2d0a2656bada0..bf7eea92852be 100644 --- a/install.js +++ b/install.js @@ -28,13 +28,17 @@ if (process.env.NPM_CONFIG_PUPPETEER_SKIP_CHROMIUM_DOWNLOAD || process.env.npm_c console.log('**INFO** Skipping Chromium download. "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" was set in npm config.'); return; } +if (process.env.NPM_PACKAGE_CONFIG_PUPPETEER_SKIP_CHROMIUM_DOWNLOAD || process.env.npm_package_config_puppeteer_skip_chromium_download) { + console.log('**INFO** Skipping Chromium download. "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" was set in project config.'); + return; +} -const downloadHost = process.env.PUPPETEER_DOWNLOAD_HOST || process.env.npm_config_puppeteer_download_host; +const downloadHost = process.env.PUPPETEER_DOWNLOAD_HOST || process.env.npm_config_puppeteer_download_host || process.env.npm_package_config_puppeteer_download_host; const puppeteer = require('./index'); const browserFetcher = puppeteer.createBrowserFetcher({ host: downloadHost }); -const revision = process.env.PUPPETEER_CHROMIUM_REVISION || process.env.npm_config_puppeteer_chromium_revision +const revision = process.env.PUPPETEER_CHROMIUM_REVISION || process.env.npm_config_puppeteer_chromium_revision || process.env.npm_package_config_puppeteer_chromium_revision || require('./package.json').puppeteer.chromium_revision; const revisionInfo = browserFetcher.revisionInfo(revision);