diff --git a/lib/ExecutionContext.js b/lib/ExecutionContext.js index f26750cc89cf2..884597200993f 100644 --- a/lib/ExecutionContext.js +++ b/lib/ExecutionContext.js @@ -47,6 +47,8 @@ class ExecutionContext { const result = await handle.jsonValue().catch(error => { if (error.message.includes('Object reference chain is too long')) return; + if (error.message.includes('Object couldn\'t be returned by value')) + return; throw error; }); await handle.dispose(); diff --git a/test/page.spec.js b/test/page.spec.js index 21ec7e61834cc..74e24b6b2a2f5 100644 --- a/test/page.spec.js +++ b/test/page.spec.js @@ -124,9 +124,9 @@ module.exports.addTests = function({testRunner, expect, puppeteer, DeviceDescrip it('should properly serialize null fields', async({page}) => { expect(await page.evaluate(() => ({a: undefined}))).toEqual({}); }); - it('should fail for window object', async({page, server}) => { - const result = await page.evaluate(() => window); - expect(result).toBe(undefined); + it('should return undefined for non-serializable objects', async({page, server}) => { + expect(await page.evaluate(() => window)).toBe(undefined); + expect(await page.evaluate(() => [Symbol('foo4')])).toBe(undefined); }); it('should fail for circular object', async({page, server}) => { const result = await page.evaluate(() => {