From fd857474cc85f03a1263e692b9e0d9e1215da6c8 Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Tue, 9 Feb 2021 11:52:35 +0000 Subject: [PATCH] chore: fix doclint violations (#6849) --- package.json | 2 +- utils/doclint/check_public_api/index.js | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index f14da8b902ace..c5fc2da461993 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "eslint": "([ \"$CI\" = true ] && eslint --ext js --ext ts --quiet -f codeframe . || eslint --ext js --ext ts .)", "eslint-fix": "eslint --ext js --ext ts --fix .", "commitlint": "commitlint --from=HEAD~1", - "lint": "npm run eslint && npm run tsc && npm run doc && npm run commitlint", + "lint": "npm run eslint && npm run build && npm run doc && npm run commitlint", "doc": "node utils/doclint/cli.js", "clean-lib": "rm -rf lib", "build": "npm run tsc && npm run generate-d-ts", diff --git a/utils/doclint/check_public_api/index.js b/utils/doclint/check_public_api/index.js index 13c62028e5319..13900c7637914 100644 --- a/utils/doclint/check_public_api/index.js +++ b/utils/doclint/check_public_api/index.js @@ -842,6 +842,21 @@ function compareDocumentations(actual, expected) { expectedName: 'ConnectOptions', }, ], + [ + 'Method Page.deleteCookie() ...cookies', + { + actualName: '...Object', + expectedName: '...DeleteCookiesRequest', + }, + ], + [ + 'Method Page.emulateVisionDeficiency() type', + { + actualName: 'string', + expectedName: + '"none"|"achromatopsia"|"blurredVision"|"deuteranopia"|"protanopia"|"tritanopia"', + }, + ], ]); const expectedForSource = expectedNamingMismatches.get(source);