Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: merge Puppeteer-Firefox tests with Puppeteer tests #3889

Closed
aslushnikov opened this issue Feb 2, 2019 · 0 comments
Closed

firefox: merge Puppeteer-Firefox tests with Puppeteer tests #3889

aslushnikov opened this issue Feb 2, 2019 · 0 comments
Labels
firefox-protocol Issues with Puppeteer-Firefox health

Comments

@aslushnikov
Copy link
Contributor

aslushnikov commented Feb 2, 2019 •
edited

When working on prototype of Puppeteer-Firefox, we were copying many Puppeteer tests, adding some others and changing a few.

This issue is to track progress on unifying tests for Puppeteer and Puppeteer-Firefox.
The roadmap:

  • bring Puppeteer-Firefox unique tests to Puppeteer
  • skip failing tests and enable Puppeteer-Firefox on CI

For the record: There's a helper script //test/difftests.js (not committed - dirty but useful) that diffs tests between Puppeteer and Puppeteer-Firefox.
@aslushnikov aslushnikov added health firefox-protocol Issues with Puppeteer-Firefox labels Feb 2, 2019
@aslushnikov aslushnikov mentioned this issue Feb 2, 2019
Merged
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): introduce vendor-specific specs
313dd08 
Certain Puppeteer methods do expose the inner browser - e.g.
`browser.version()` depends on the browser we run.

Split out these tests into a vendor-specific test suites.

References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 2, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): introduce vendor-specific specs (#3890)
6bb0350 
Certain Puppeteer methods do expose the inner browser - e.g.
`browser.version()` depends on the browser we run.

Split out these tests into a vendor-specific test suites.

References #3889
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): add puppeteer-firefox unique evaluation tests
f5cb5b6 
References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 2, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): add puppeteer-firefox unique evaluation tests (#3891)
b5e53fd 
References #3889
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): add more Puppeteer-Firefox tests to Puppeteer
eb04110 
References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 2, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): add more Puppeteer-Firefox tests to Puppeteer (#3892)
47fbb11 
References #3889
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 2, 2019
@aslushnikov
test(firefox): further unify Puppeteer-Firefox and Puppeteer tests
e77f737 
This patch:
- changes Puppeteer-Firefox plumbing of defaultBrowserOptions to align
  with the way we do it for Puppeteer.
- plumbs puppeeteer-dependent Errors and DeviceDescriptors down to every
  test.
- unifies a few tests between Puppeteer-Firefox and Puppeteer.

**Note:** in future, we should expose errors as `puppeteer.errors` and
device descriptors as `puppeteer.devices` to make it easy to pass around
Puppeteer/Puppeteer-Firefox instance.

References puppeteer#3889.
@aslushnikov aslushnikov mentioned this issue Feb 2, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 3, 2019
@aslushnikov
test(firefox): further unify Puppeteer-Firefox and Puppeteer tests (#…
69c434a 
…3894)

This patch:
- changes Puppeteer-Firefox plumbing of defaultBrowserOptions to align
  with the way we do it for Puppeteer.
- plumbs puppeeteer-dependent Errors and DeviceDescriptors down to every
  test.
- unifies a few tests between Puppeteer-Firefox and Puppeteer.

**Note:** in future, we should expose errors as `puppeteer.errors` and
device descriptors as `puppeteer.devices` to make it easy to pass around
Puppeteer/Puppeteer-Firefox instance.

References #3889.
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 4, 2019
@aslushnikov
test(firefox): support Puppeteer-Firefox specific env variables
6dd8524 
This patch:
- adds support to `FFOX` env variable for Puppeteer testsuite
- install Firefox preferences when running tests with custom firefox
  executable

References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 4, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 5, 2019
@aslushnikov
test(firefox): support Puppeteer-Firefox specific env variables (#3907)
dd8bd6d 
This patch:
- adds support to `FFOX` env variable for Puppeteer testsuite
- install Firefox preferences when running tests with custom firefox
  executable

References #3889
@aslushnikov aslushnikov mentioned this issue Feb 6, 2019
Merged
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 6, 2019
@aslushnikov
chore(firefox): run all tests without "UnhandledPromiseRejection" error
0cb9f27 
This aligns all Puppeteer tests so that they never throw the
"UnhandledPromiseRejection" when run with Puppeteer-Firefox.

With this patch, the `npm run funit` passes 275 of 460 Puppeteer tests.

References puppeteer#3889.
@aslushnikov aslushnikov mentioned this issue Feb 6, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 6, 2019
@aslushnikov
chore(firefox): run all tests without "UnhandledPromiseRejection" err…
86783c2 
…or (#3922)

This aligns all Puppeteer tests so that they never throw the
"UnhandledPromiseRejection" when run with Puppeteer-Firefox.

With this patch, the `npm run funit` passes 275 of 460 Puppeteer tests.

References #3889.
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 6, 2019
@aslushnikov
chore(firefox): mark all Puppeteer tests that are failing on FF
6991a94 
This patch:
- introduces new testRunner methods `addTestDSL` and `addSuiteDSL`
  to add annotated test / suite.
- introduces new test/suite declaration methods: `it_fails_ffox` and
  `describe_fails_ffox`. These are equal to `it`/`describe` for chromium
  tests and to `xit`/`xdescribe` for firefox.
- marks all unsupported tests with `it_fails_ffox`
- adds a new command-line flag `'--firefox-status'` to `//test/test.js`.
  This flag dumps current amount of tests that are intentionally skipped
  for Firefox.

End goal: get rid of all `it_fails_ffox` and `describe_fails_ffox`
tests.

Drive-By: remove cookie tests  "afterEach" hook that was removing
cookies - it's not needed any more since every test is run in a
designated browser context.

References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 6, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 6, 2019
@aslushnikov
chore(firefox): mark all Puppeteer tests that are failing on FF (#3924)
14fb3e3 
This patch:
- introduces new testRunner methods `addTestDSL` and `addSuiteDSL`
  to add annotated test / suite.
- introduces new test/suite declaration methods: `it_fails_ffox` and
  `describe_fails_ffox`. These are equal to `it`/`describe` for chromium
  tests and to `xit`/`xdescribe` for firefox.
- marks all unsupported tests with `it_fails_ffox`
- adds a new command-line flag `'--firefox-status'` to `//test/test.js`.
  This flag dumps current amount of tests that are intentionally skipped
  for Firefox.

End goal: get rid of all `it_fails_ffox` and `describe_fails_ffox`
tests.

Drive-By: remove cookie tests  "afterEach" hook that was removing
cookies - it's not needed any more since every test is run in a
designated browser context.

References #3889
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 6, 2019
@aslushnikov
chore: further unify Puppeteer-Firefox tests with Puppeteer
f5bf476 
This patch:
- unifies assets between tests
- enables a few puppeteer tests on Puppeteer-Firefox

References puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 6, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 6, 2019
@aslushnikov
chore: further unify Puppeteer-Firefox tests with Puppeteer (#3931)
6887ad8 
This patch:
* unifies assets between tests
* enables a few puppeteer tests on Puppeteer-Firefox

Drive-by: beautify failing output of `expect.toEqual` matcher.

References #3889
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 21, 2019
@aslushnikov
chore(firefox): kill original puppeteer-firefox tests
f6acf43 
When we started working on Puppeteer-Firefox, we forked original
Puppeteer testsuite.

This patch concludes the effort to merge testsuites back together.

Fixes puppeteer#3889
@aslushnikov aslushnikov mentioned this issue Feb 21, 2019
Merged
aslushnikov added a commit that referenced this issue Feb 21, 2019
@aslushnikov
chore(firefox): kill original puppeteer-firefox tests (#4047)
ed984ac 
When we started working on Puppeteer-Firefox, we forked original
Puppeteer testsuite.

This patch concludes the effort to merge testsuites back together.

Fixes #3889
kiku-jw pushed a commit to kiku-jw/puppeteer that referenced this issue Apr 6, 2019
@aslushnikov @kiku-jw
chore(firefox): kill original puppeteer-firefox tests (puppeteer#4047)
3caef0b 
When we started working on Puppeteer-Firefox, we forked original
Puppeteer testsuite.

This patch concludes the effort to merge testsuites back together.

Fixes puppeteer#3889
This was referenced Feb 3, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this issue May 5, 2020
Open
This was referenced Mar 13, 2021
Open
Open
Open
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
firefox-protocol Issues with Puppeteer-Firefox health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov