New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: strict mode fixes for HTTPRequest/Response classes #8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
strict-mode-requests
branch
2 times, most recently
from
May 2, 2022 10:41
753ea0e
to
de44d9c
Compare
ergunsh
reviewed
May 3, 2022
OrKoN
force-pushed
the
strict-mode-requests
branch
from
May 4, 2022 06:19
de44d9c
to
e00d98c
Compare
OrKoN
changed the title
fix: strict mode fixes for HTTPRequest/Response classes
fix!: strict mode fixes for HTTPRequest/Response classes
May 4, 2022
OrKoN
force-pushed
the
strict-mode-requests
branch
from
May 4, 2022 06:27
e00d98c
to
53c0394
Compare
ergunsh
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM with 1 comment on STATUS_TEXTS
and response
typing.
Apart from that, I had a comment on the nature of introducing breaking changes in a minor version and I don't have a strong opinion on that one. If you think that is acceptable, this is good to go! 🥳
OrKoN
force-pushed
the
strict-mode-requests
branch
from
May 4, 2022 09:22
53c0394
to
964ea8e
Compare
Solves type issues in HTTPRequest/Response with some slight changes in the behaviour and API. Issues #6769
OrKoN
force-pushed
the
strict-mode-requests
branch
from
May 5, 2022 06:27
964ea8e
to
3d2541a
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves type issues in HTTPRequest/Response with some slight changes in the behaviour and API.
Issues #6769