feat: expose CDPSession.detached#13615
Merged
Lightning00Blade merged 1 commit intoFeb 17, 2025
Merged
Conversation
alexey-pelykh
force-pushed
the
feat/expose-CDPSession-detached
branch
from
aa54797 to
add1b36
Compare
alexey-pelykh
force-pushed
the
feat/expose-CDPSession-detached
branch
from
add1b36 to
4b14f12
Compare
alexey-pelykh
force-pushed
the
feat/expose-CDPSession-detached
branch
from
4b14f12 to
89f66b9
Compare
Lightning00Blade
approved these changes
Feb 17, 2025
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR.
Lightning00Blade
approved these changes
Feb 17, 2025
Merged
Closed
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different perspective to #13613
What kind of change does this PR introduce?
Feature/Refactor:
CdpCDPSession.connection()behavior contracted by test; addCDPSession.detachedDid you add tests for your changes?
Yes
If relevant, did you update the documentation?
Code comments only.
Summary
#13591 and #13613 raised a question that
CdpCDPSession.connection()behavior was not explicitly defined.Does this PR introduce a breaking change?
No