refactor: use stricter CDP implementation type of CDPSession - #13620
Conversation
Lightning00Blade
left a comment
There was a problem hiding this comment.
I would prefer to not include a runtime checks when this is internal code, that users won't ever interact with, TypeScript safety should be enough for internal parts.
(I know that there was already one, but that should not be there as well).
I looked into changing the types, only and it looked like it was failing in a couple of places due to changing the constructor. And without that change other places don't benefit as much with this change.
4c769ac to
426d7a2
Compare
|
@Lightning00Blade thanks for the review! Your points are perfectly valid - I've tried to avoid runtime checks and gradually replace non-CDP-specific types with CDP-specific ones and eventually got success, at least it looks like it. |
Lightning00Blade
left a comment
There was a problem hiding this comment.
Thanks for the PR, left some comments.
dbd6750 to
e4003c7
Compare
e4003c7 to
ccb9f41
Compare
Lightning00Blade
left a comment
There was a problem hiding this comment.
Over all looks really good, thanks for the PR.
Left some comments, that need to be fixed before merging
23bddda to
acca085
Compare
acca085 to
760c8cd
Compare
760c8cd to
dec4b70
Compare
|
Thanks for the PR. |
What kind of change does this PR introduce?
Tiny typing improvement.
Did you add tests for your changes?
There's no functional change
If relevant, did you update the documentation?
No - nothing affected
Summary
As a part of #13613 there were few typing changes so that CDP FrameManager uses CDP-specific session.
Does this PR introduce a breaking change?
Nope
Other information
N/A