feat(api): add page.emulateTimezone(timezoneId) #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Sep 18, 2019
mathiasbynens
force-pushed
the
emulatetimezone
branch
from
683bcd2
to
56c6743
Compare
mathiasbynens
force-pushed
the
emulatetimezone
branch
from
56c6743
to
a8c9eea
Compare
mathiasbynens
force-pushed
the
emulatetimezone
branch
from
a8c9eea
to
d62aea8
Compare
This enables dynamically changing the timezone of the page.
mathiasbynens
force-pushed
the
emulatetimezone
branch
from
d62aea8
to
6072b66
Compare
|
@mathiasbynens I'm curious to know what's needed or if this will make it into puppeteer? thx! |
|
@crobinson42 It's currently blocked on a Chromium roll. You can track the progress of that here: #5058 It sounds like you have a use case for this feature? Please let us know what you plan on doing with it :) |
szuend
approved these changes
Oct 23, 2019
| try { | ||
| await this._client.send('Emulation.setTimezoneOverride', {timezoneId: timezoneId || ''}); | ||
| } catch (exception) { | ||
| if (exception.message.includes('Invalid timezone')) |
There was a problem hiding this comment.
nit: Braces for multi-line if.
There was a problem hiding this comment.
The current puppeteer code style doesn't allow braces around single-line if bodies.
Co-Authored-By: Simon <simon.zuend@gmail.com>
|
CLAs look good, thanks! |
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This enables dynamically changing the timezone of the page.
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This enables dynamically changing the timezone of the page.
Blocked on a Chromium roll to v79.0.3923.0 (r699550) or later, though.