Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom debugging port option #4993

Merged
merged 5 commits into from Sep 29, 2021

Conversation

@tanhauhau
Copy link
Contributor

@tanhauhau tanhauhau commented Oct 1, 2019

I found out that the only way to customise the debugging port for now is to pass in the --remote-debugging-port as args:

puppeteer.laucnh({ args: ['--remote-debugging-port=12345'] })
@tanhauhau tanhauhau force-pushed the tanhauhau/custom-debugging-port branch from 5f6b741 to b700ccf Oct 1, 2019
@tanhauhau tanhauhau force-pushed the tanhauhau/custom-debugging-port branch from b700ccf to 8802d83 Oct 1, 2019
@mathiasbynens mathiasbynens changed the base branch from master to main Jun 15, 2020
@mathiasbynens mathiasbynens force-pushed the main branch 4 times, most recently from 03a4ca1 to d4b17bd Sep 3, 2021
@jschfflr jschfflr self-requested a review Sep 11, 2021
Copy link
Contributor

@jschfflr jschfflr left a comment

@tanhauhau Thanks for your contribution!
Could you update this patch to resolve the merge conflicts and make sure to add test coverage for this feature? chromiumonly.spec.ts looks like a promising starting point but ideally, Firefox would also be covered.

lib/Launcher.js Outdated
@@ -249,6 +250,8 @@ class Launcher {
'--mute-audio'
);
}
if (debuggingPort)
Copy link
Contributor

@jschfflr jschfflr Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation, you stated that passing 0 for the debuggingPort will assign a random port but I think this if clause will prevent that from happening.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 29, 2021
@jschfflr
Copy link
Contributor

@jschfflr jschfflr commented Sep 29, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 29, 2021
@jschfflr jschfflr merged commit 26145e9 into puppeteer:main Sep 29, 2021
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants