docs: page.waitFor options object defination

[theeko]

Added options descriptiptions for page.waitFor.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[theeko]

signed

[mathiasbynens]

What about the hidden attribute?

Maybe it's better to not explicitly list the examples (like display: none or visibility: hidden) here.

[theeko]

Changed as requested. Examples are not listed anymore. Just shows default value and description.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[mathiasbynens]

LGTM but before we merge this, we should make the linter happy and make sure the CI checks pass.

[mathiasbynens]

LGTM but before we merge this, we should make the linter happy and make sure the CI checks pass.

To do this, https://github.com/GoogleChrome/puppeteer/blob/1248a19135fe54b8fe42e15435c11c3c8aa949d2/lib/Page.js#L1111 needs to be updated accordingly.

[theeko]

Checks are 9/10.
Dont know what last error is (Travis CI - Pull Request Action required after 10m — Build Errored)
Can you guide me.

[mathiasbynens]

@theeko The remaining failure seems unrelated to your change. I've just restarted the build.

[mathiasbynens]

Thanks!

[theeko]

Thanks for guidance Mathias.