Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node.js v6 support #5045

Merged
merged 8 commits into from Oct 16, 2019
Merged

chore: drop Node.js v6 support #5045

merged 8 commits into from Oct 16, 2019

Conversation

mathiasbynens
Copy link
Member

As discussed offline, I'll be taking @aslushnikov's PR from #4654 and (hopefully!) bring it across the finish line. 馃憤

aslushnikov and others added 3 commits July 2, 2019 00:43
Node6 was end-of-life'ed in the end of April, 2019, with AWS Lambda
prohibiting updaets to the node6 runtime since June 30, 2019.

This makes it quite safe for us to remove the Node 6 support from the
repository.

From now on, all the subsequent commits will require Node 8.9.0+.
Merge branch 'bye-node-6' of https://github.com/aslushnikov/puppeteer into aslushnikov-bye-node-6

* 'bye-node-6' of https://github.com/aslushnikov/puppeteer:
  Remove supportsAsyncAwait
  chore: drop Node6 support
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@mathiasbynens mathiasbynens added breaking change This changes the API in a way that requires a major release. health P1 labels Oct 16, 2019
@mathiasbynens mathiasbynens force-pushed the aslushnikov-bye-node-6 branch 2 times, most recently from f835a1d to 9cf5335 Compare October 16, 2019 11:18
@mathiasbynens mathiasbynens force-pushed the aslushnikov-bye-node-6 branch 3 times, most recently from 85b577a to 1810233 Compare October 16, 2019 13:17
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

鈩癸笍 Googlers: Go here for more info.

@mathiasbynens mathiasbynens merged commit 11ff374 into master Oct 16, 2019
@mathiasbynens mathiasbynens deleted the aslushnikov-bye-node-6 branch October 16, 2019 15:00
@aslushnikov aslushnikov mentioned this pull request Oct 16, 2019
13 tasks
thomasdondorf added a commit to thomasdondorf/puppeteer-cluster that referenced this pull request Dec 5, 2019
rfojtik pushed a commit to rfojtik/puppeteer that referenced this pull request Dec 21, 2019
Node.js v6 was end-of-life'd in April, 2019, with AWS Lambda prohibiting updaets to the Node.js v6 runtime since June 30, 2019.

This makes it quite safe for us to remove the Node 6 support from the repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This changes the API in a way that requires a major release. cla: yes health P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants