Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create `node` directory for Node-only files #6041

Merged
merged 1 commit into from Jun 18, 2020

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 18, 2020

This is another step towards making Puppeteer agnostic of environment
and being able to run in Node or a browser.

The files in the node directory are ones that would only be needed in
the Node build - e.g. the code that downloads and launches a local
browser instance.

The long term vision here is to have three folders:

  • node - Node only code
  • web - Web only code
  • common - code that is shared

But rather than do that in one PR I'm going to split it up to make it
easier to review and deal with.

@googlebot googlebot added the cla: yes label Jun 18, 2020
@jackfranklin jackfranklin requested a review from mathiasbynens Jun 18, 2020
This is another step towards making Puppeteer agnostic of environment
and being able to run in Node or a browser.

The files in the `node` directory are ones that would only be needed in
the Node build - e.g. the code that downloads and launches a local
browser instance.

The long term vision here is to have three folders:

* node - Node only code
* web - Web only code
* common - code that is shared

But rather than do that in one PR I'm going to split it up to make it
easier to review and deal with.
@jackfranklin jackfranklin force-pushed the create-node-directory branch from adac232 to 7bb2bf1 Jun 18, 2020
@jackfranklin jackfranklin merged commit 90b0934 into main Jun 18, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the create-node-directory branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.