Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): migrate TimeoutError to TSDoc #6062

Merged
merged 2 commits into from Jun 22, 2020
Merged

docs(new): migrate TimeoutError to TSDoc #6062

merged 2 commits into from Jun 22, 2020

Conversation

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 22, 2020

No description provided.

@OrKoN OrKoN requested review from mathiasbynens and jackfranklin Jun 22, 2020
@googlebot googlebot added the cla: yes label Jun 22, 2020
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 22, 2020

@jackfranklin it looks like the tests fail? Did I do something wrong here?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 22, 2020

It looks like CI is using api-documenter 7.8.13 and my local version after npm install is 7.8.12

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 22, 2020

It looks like CI is using api-documenter 7.8.13 and my local version after npm install is 7.8.12

Ah, we should probably hard pin this dependency to make sure there are no output differences locally vs CI. I'll do that in a PR now and that should resolve this.

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 22, 2020

#6063 should enable this to go green!

Alex Rudenko added 2 commits Jun 22, 2020
Alex Rudenko
@OrKoN OrKoN force-pushed the tsdoc-timeout-error branch from 1b84ae7 to fb63b32 Jun 22, 2020
@OrKoN OrKoN merged commit 1cf3f06 into main Jun 22, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@OrKoN OrKoN deleted the tsdoc-timeout-error branch Jun 22, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
* docs(new): migrate TimeoutError to TSDoc

Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.